Skip to content

[Chore] Removed use of matrix in python style check workflow jobs #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

oleksandr-pavlyk
Copy link
Contributor

Some jobs of python-style-check workflow used matrix to choose Python version, resulting in python-version dependent job names. This made it cumbersome to refer to such jobs in branch protection rules.

This PR removes use of matrix, hard-coding the Python version name inside the parameters of respective jobs.

  • Have you provided a meaningful PR description?

@oleksandr-pavlyk oleksandr-pavlyk changed the title No need to use matrix if using single Python version [Chore] No need to use matrix if using single Python version Nov 4, 2022
@oleksandr-pavlyk oleksandr-pavlyk changed the title [Chore] No need to use matrix if using single Python version [Chore] Removed use of matrix in python style check workflow jobs Nov 4, 2022
@oleksandr-pavlyk oleksandr-pavlyk merged commit 94fc13f into master Nov 4, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the remove-python-version-matrix-from-style-checks branch November 4, 2022 19:28
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 82.033% when pulling 9185994 on remove-python-version-matrix-from-style-checks into 78c443b on master.

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_4 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_4 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants