FIX: random shuffle for ndim arrays #1037
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed setting high_dim_size var
samir-nasibli
requested review from
KsanaKozlova,
densmirn,
LukichevaPolina and
Alexander-Makaryev
densmirn
approved these changes
Oct 28, 2021
|
We need to unskip test |
enabled related test case
|
@Alexander-Makaryev will this pr be merged? |
|
Closed since no plans to implement that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
high_dim_sizevariable on cython levelRoot cause
Setting
high_dim_sizevariable value was accidentally changed on #953, see https://github.com/IntelPython/dpnp/pull/953/files#diff-848ee382ceb656b32b8b6a920adc5a66bf65c04af2789d34beca1af7209cf898R839len(multidim_array)shouldn't be equal to its whole sizemultidim_array.size()for ndim array. so #953 bad fix for this.TODO
update/reimplement tests for shuffle