Skip to content

standardize the stride in matmul function #1828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 16, 2024
Merged

standardize the stride in matmul function #1828

merged 4 commits into from
May 16, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented May 15, 2024

In this PR, strides are standardized before using in different places in dpnp.matmul to make sure the code always behave in the expected way.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this May 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/1828/index.html

@vtavana vtavana mentioned this pull request May 15, 2024
Merged
6 tasks
@vtavana vtavana marked this pull request as ready for review May 15, 2024 22:08
antonwolfy
antonwolfy approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana for a quick fix.

@antonwolfy antonwolfy merged commit 86c8640 into master May 16, 2024
@antonwolfy antonwolfy deleted the standardize_stride branch May 16, 2024 19:51
github-actions bot added a commit that referenced this pull request May 16, 2024
@github-actions
standardize the stride in matmul function (#1828)
e825475 
* standardize the stride in matmul function

* remove unused varibale

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 86c8640
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy