Skip to content

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Jul 15, 2024

In this PR, a few minor changes are made in matmul function:

  1. a TODO is removed since now that dpnp.are_same_logical_tensors check is added to get_result_array function.
  2. maximum batch size that can be used in MKL function, is updated. The current value is validated to work on Intel Iris Xe and PVC GPUs.
  3. The usm_type of out keyword in matmul function does not need to match the usm_type of input arrays, the corresponding check is removed.
  4. minor changes are made to organize the code
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Jul 15, 2024
Copy link
Contributor

github-actions bot commented Jul 15, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review July 15, 2024 16:24
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana for the improvements implements and for the great explanation in review comments. The behavior is much more clear now for me.

@vtavana vtavana merged commit 033378d into master Jul 17, 2024
@vtavana vtavana deleted the clean-gemm branch July 17, 2024 14:38
github-actions bot added a commit that referenced this pull request Jul 17, 2024
* clean-up

* address comments 033378d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants