Add device, sycl_queue and usm_type keywords to dpnp.ndarray.copy method
#1976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
requested review from
npolina4,
vtavana and
vlad-perevezentsev
and removed request for
npolina4
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
vtavana
approved these changes
Aug 10, 2024
There was a problem hiding this comment.
Thank you, @antonwolfy!
I have made a few edits that are not directly tied to the sections being modified, which made it difficult to add comments. Therefore, I found it simpler to make these changes directly instead of suggesting where such modifications could be made.
github-actions bot
added a commit
that referenced
this pull request
Aug 12, 2024
…ethod (#1976) * Add device, sycl_queue and usm_type keywords to dpnp.ndarray.copy * Align description of sycl_queue keyword * Applied black formatting * Updated third party tests * Added tests for SYCL queue and USM device * update fftfreq and rfftfreq docstring --------- Co-authored-by: Vahid Tavanashad <vahid.tavanashad@intel.com> Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com> 6ae16ce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to extend
dpnp.ndarray.copymethod withdevice,sycl_queueandusm_typekeywords.Additionally, the description of
sycl_queuekeyword is aligned with other dpnp functions.The tests are added to cover new keywords for
dpnp.ndarray.copyandcopy.copymethods.Affected third party tests are unmuted.