Skip to content

Post a comments with link to built docs for PR from forked repo #2146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Nov 4, 2024

The PR enables posting a comment with link to rendered documentation for a PR from forked repository.

Previously the check was based on repo data of a pull request entry (i.e. github.event.pull_request.head.repo). It means the step with comment will be disable for a PR created in forked repo. But it can merged either into fork repo itself or into original repo (i.e. the repo it was forked from). And the second option is valid, i.e. it has to be allowed posting a comment with docs for a PR coming from the fork but into the origin repo.
To do that it is proposed to check fork property of github.event.pull_request.base.repo entry, i.e. info about repo where the PR is going to be merged.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

Copy link
Contributor

github-actions bot commented Nov 4, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @antonwolfy

@antonwolfy antonwolfy merged commit cb801da into master Nov 4, 2024
45 of 46 checks passed
@antonwolfy antonwolfy deleted the post-comment-with-docs-for-pr-from-forked-repo branch November 4, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants