Skip to content

get rid of explicit instantiation in fft backend #2374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

get rid of explicit instantiation in fft backend #2374

merged 1 commit into from
Mar 20, 2025

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Mar 19, 2025

In this PR, explicit instantiation of compute_fft_in_place and compute_fft_out_of_place functions in the backend is replaced with including a template definition.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vtavana vtavana self-assigned this Mar 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 19, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 71.763%. remained the same
when pulling 2902646 on simplify-fft
into 764f92c on master.

@github-actions GitHub Actions
Copy link
Contributor

Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_34 ran successfully.
Passed: 1006
Failed: 0
Skipped: 17

@vtavana vtavana marked this pull request as ready for review March 19, 2025 20:27
antonwolfy
antonwolfy approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana for the improvement and code clean up.

@vtavana vtavana merged commit 337becf into master Mar 20, 2025
68 checks passed
@vtavana vtavana deleted the simplify-fft branch March 20, 2025 09:59
github-actions bot added a commit that referenced this pull request Mar 20, 2025
@github-actions
get rid of explicit instantiation in fft backend (#2374)
dbf6400 
In this PR, explicit instantiation of `compute_fft_in_place` and
`compute_fft_out_of_place` functions in the backend is replaced with
including a template definition. 337becf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtavana @coveralls @antonwolfy