Skip to content

update a utility function in FFT module #2393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 28, 2025
Merged

update a utility function in FFT module #2393

merged 4 commits into from
Mar 28, 2025

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Mar 26, 2025 •
edited
Loading

In this PR, a utility function in FFT module is updated to remove duplication.
In addition a new test is added to make coverage for FFT module 100%.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vtavana vtavana self-assigned this Mar 26, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 26, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

coveralls commented Mar 26, 2025 •
edited
Loading

Coverage Status

coverage: 72.209% (+0.004%) from 72.205%
when pulling f0b6492 on update_norm_FFT
into a567221 on master.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 26, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_55 ran successfully.
Passed: 1197
Failed: 0
Skipped: 14

@vtavana vtavana force-pushed the update_norm_FFT branch 2 times, most recently from a4a76ca to d719b0a Compare March 27, 2025 00:16
@vtavana vtavana marked this pull request as ready for review March 27, 2025 03:05
antonwolfy
antonwolfy approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana for the improvement.
In overall LGTM, just few minor nits for new test.

vtavana and others added 2 commits March 27, 2025 06:27
@vtavana @antonwolfy
Apply suggestions from code review
e2fdb83 
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
@antonwolfy
Merge branch 'master' into update_norm_FFT
af2f031
@vtavana vtavana merged commit 05b820d into master Mar 28, 2025
68 checks passed
@vtavana vtavana deleted the update_norm_FFT branch March 28, 2025 16:15
github-actions bot added a commit that referenced this pull request Mar 28, 2025
@github-actions
update a utility function in FFT module (#2393)
d157077 
In this PR, a utility function in FFT module is updated to remove
duplication.
In addition a new test is added to make coverage for FFT module 100%. 05b820d
@vtavana vtavana mentioned this pull request Mar 28, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtavana @coveralls @antonwolfy