Skip to content

Clarify order of indices returned in dpnp.tril_indices and dpnp.triu_indices #2586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 22, 2025
Merged

Clarify order of indices returned in dpnp.tril_indices and dpnp.triu_indices #2586

merged 2 commits into from
Sep 22, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Sep 22, 2025 •
edited
Loading

The PR updates docstrings to clarify the order of indices returned by the functions.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.19.0 release milestone Sep 22, 2025
@antonwolfy antonwolfy self-assigned this Sep 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 22, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 71.78%. remained the same
when pulling 5052ae9 on clarify-docstrings-in-tril_indices-and-triu_indices
into 66b9b3b on master.

@github-actions GitHub Actions
Copy link
Contributor

Array API standard conformance tests for dpnp=0.19.0dev4=py313h509198e_7 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

vlad-perevezentsev
vlad-perevezentsev approved these changes Sep 22, 2025
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit b27a7ca into master Sep 22, 2025
71 of 75 checks passed
@antonwolfy antonwolfy deleted the clarify-docstrings-in-tril_indices-and-triu_indices branch September 22, 2025 11:55
github-actions bot added a commit that referenced this pull request Sep 22, 2025
@github-actions
Clarify order of indices returned in dpnp.tril_indices and `dpnp.tr…
c357b4e 
…iu_indices` (#2586)

The PR updates docstrings to clarify the order of indices returned by
the functions. b27a7ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
0.19.0 release
Development

Successfully merging this pull request may close these issues.
3 participants
@antonwolfy @coveralls @vlad-perevezentsev