Resolve an issue with cyclic import in linalg submodule
#2608
+64
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
requested review from
vlad-perevezentsev and
ndgrigorian
as code owners
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
|
Array API standard conformance tests for dpnp=0.19.0rc0=py313h509198e_11 ran successfully. |
vlad-perevezentsev
approved these changes
Oct 6, 2025
antonwolfy
added a commit
that referenced
this pull request
Oct 6, 2025
The PR reworks the import of `linalg` submodule to avoid a wildcard import. Also it resolves the issue reported by pylint: > Cyclic import (dpnp.linalg -> dpnp.linalg.dpnp_iface_linalg -> dpnp.linalg.dpnp_utils_linalg) (cyclic-import) and moves `LinAlgError` exception to be exposed by LAPACK pybind11 extension, because it is created there. While later the exception patched at python level to be set to "dpnp.linalg" submodule explicitly. Otherwise we have the import cycle like: > linalg/__init__.py -> dpnp_iface_linalg.py -> dpnp_utils_linalg.py -> linalg/__init__.py which might cause the import failure.
antonwolfy
added a commit
that referenced
this pull request
Oct 6, 2025
The PR reworks the import of `linalg` submodule to avoid a wildcard import. Also it resolves the issue reported by pylint: > Cyclic import (dpnp.linalg -> dpnp.linalg.dpnp_iface_linalg -> dpnp.linalg.dpnp_utils_linalg) (cyclic-import) and moves `LinAlgError` exception to be exposed by LAPACK pybind11 extension, because it is created there. While later the exception patched at python level to be set to "dpnp.linalg" submodule explicitly. Otherwise we have the import cycle like: > linalg/__init__.py -> dpnp_iface_linalg.py -> dpnp_utils_linalg.py -> linalg/__init__.py which might cause the import failure.
github-actions bot
added a commit
that referenced
this pull request
Oct 6, 2025
The PR reworks the import of `linalg` submodule to avoid a wildcard import. Also it resolves the issue reported by pylint: > Cyclic import (dpnp.linalg -> dpnp.linalg.dpnp_iface_linalg -> dpnp.linalg.dpnp_utils_linalg) (cyclic-import) and moves `LinAlgError` exception to be exposed by LAPACK pybind11 extension, because it is created there. While later the exception patched at python level to be set to "dpnp.linalg" submodule explicitly. Otherwise we have the import cycle like: > linalg/__init__.py -> dpnp_iface_linalg.py -> dpnp_utils_linalg.py -> linalg/__init__.py which might cause the import failure. 285c313
antonwolfy
added a commit
that referenced
this pull request
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR reworks the import of
linalgsubmodule to avoid a wildcard import.Also it resolves the issue reported by pylint:
and moves
LinAlgErrorexception to be exposed by LAPACK pybind11 extension, because it is created there.While later the exception patched at python level to be set to "dpnp.linalg" submodule explicitly.
Otherwise we have the import cycle like:
which might cause the import failure.