Skip to content

Resolve pybind11 CMake message #2614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 9, 2025
Merged

Resolve pybind11 CMake message #2614

merged 3 commits into from
Oct 9, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Oct 8, 2025 •
edited
Loading

This PR silences the message

Using compatibility mode for Python, set PYBIND11_FINDPYTHON to NEW/OLD to silence this message

The message is gone when find_package(Python REQUIRED COMPONENTS Development.Module) is done before fetching pybind11, as Python_FOUND will be set.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.20.0 release milestone Oct 8, 2025
@antonwolfy antonwolfy self-assigned this Oct 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.20.0dev0=py313h509198e_4 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@antonwolfy antonwolfy marked this pull request as ready for review October 8, 2025 11:09
@antonwolfy antonwolfy force-pushed the resolve-cmake-warning-module-development branch from 336ccc6 to 77dc873 Compare October 8, 2025 11:12
vlad-perevezentsev
vlad-perevezentsev reviewed Oct 8, 2025
View reviewed changes
@coveralls
Copy link
Collaborator

coveralls commented Oct 8, 2025 •
edited
Loading

Coverage Status

Changes unknown
when pulling 2f5a777 on resolve-cmake-warning-module-development
into ** on master**.

@antonwolfy @vlad-perevezentsev
Update CHANGELOG.md
2f5a777 
Co-authored-by: vlad-perevezentsev <vladislav.perevezentsev@intel.com>
@vlad-perevezentsev vlad-perevezentsev self-requested a review October 8, 2025 12:00
vlad-perevezentsev
vlad-perevezentsev approved these changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @antonwolfy !

@antonwolfy antonwolfy merged commit c27aae9 into master Oct 9, 2025
75 checks passed
@antonwolfy antonwolfy deleted the resolve-cmake-warning-module-development branch October 9, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
0.20.0 release
Development

Successfully merging this pull request may close these issues.
3 participants
@antonwolfy @coveralls @vlad-perevezentsev