Skip to content

Conversation

samir-nasibli
Copy link

@samir-nasibli samir-nasibli commented Dec 6, 2020

Description

I removed size check from python level since it is handled by dpnp.dparray.
Also it fixes limitation for size types.

Removed size assignee on random funcs level, when given size is default value(None)

@samir-nasibli samir-nasibli requested a review from shssf December 6, 2020 02:19
@codecov
Copy link

codecov bot commented Dec 6, 2020

Codecov Report

Merging #357 (84b74fd) into master (489b970) will increase coverage by 3.66%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
+ Coverage   52.09%   55.76%   +3.66%     
==========================================
  Files          24       24              
  Lines        2100     1953     -147     
  Branches      646      554      -92     
==========================================
- Hits         1094     1089       -5     
+ Misses        590      501      -89     
+ Partials      416      363      -53     
Impacted Files Coverage Δ
dpnp/random/dpnp_iface_random.py 54.60% <ø> (+16.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 489b970...84b74fd. Read the comment docs.

@shssf shssf merged commit b324990 into master Dec 6, 2020
@shssf shssf deleted the samir-nasibli/fix/random_size_check branch December 6, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants