Fix power #500
Merged
Fix power #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
densmirn
reviewed
Jan 19, 2021
| res_type = x1.dtype | ||
| if isinstance(x2, float) and (res_type == dpnp.int64 or res_type == dpnp.int32): | ||
| res_type = dpnp.float64 | ||
| result = dparray(x1.size, dtype=res_type) |
There was a problem hiding this comment.
Suggested change
| result = dparray(x1.size, dtype=res_type) | |
| result = dparray(x1.shape, dtype=res_type) |
to avoid reshape in further
| return call_fptr_2in_1out(DPNP_FN_POWER, x1, x2, x1.shape) | ||
| cpdef dparray dpnp_power(dparray x1, x2): | ||
| cdef dparray result | ||
| if dpnp.isscalar(x2): |
There was a problem hiding this comment.
Do we have any test that covers the branch?
densmirn
reviewed
Jan 19, 2021
| cdef dparray result | ||
| if dpnp.isscalar(x2): | ||
| res_type = x1.dtype | ||
| if isinstance(x2, float) and (res_type == dpnp.int64 or res_type == dpnp.int32): |
There was a problem hiding this comment.
E.g. such approach
dpnp/dpnp/dpnp_algo/dpnp_algo_mathematical.pyx
Lines 139 to 147 in c56b575
shssf
reviewed
Jan 20, 2021
| x2_ = dpnp.array([x2]) | ||
|
|
||
| types_map = { | ||
| (dpnp.dtype(dpnp.int32), dpnp.dtype(dpnp.float64)): dpnp.float64, |
There was a problem hiding this comment.
it looks like it needs to be adjusted to the same things as you did in other PR
densmirn
reviewed
Jan 20, 2021
| cpdef dparray dpnp_power(dparray x1, x2): | ||
| cdef dparray result | ||
| if dpnp.isscalar(x2): | ||
| x2_ = dpnp.array([x2]) |
There was a problem hiding this comment.
Is it possible to avoid creating one-element array?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.