add gradient function #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
densmirn
reviewed
Jan 19, 2021
| @@ -294,6 +294,27 @@ cpdef dparray dpnp_fmod(dparray x1, dparray x2): | |||
| return call_fptr_2in_1out(DPNP_FN_FMOD, x1, x2, x1.shape) | |||
|
|
|||
|
|
|||
| cpdef dparray dpnp_gradient(dparray y1, int dx=1): | |||
|
|
|||
| len = y1.size | |||
There was a problem hiding this comment.
len is built-in name. Let's rename the variable, e.g. size.
dpnp/dpnp_iface_mathematical.py
Outdated
| if not use_origin_backend(y1) and not kwargs: | ||
| if not isinstance(y1, dparray): | ||
| pass | ||
| elif len(varargs) != 0 and not isinstance(varargs[0], int): |
There was a problem hiding this comment.
What if len(varargs) = 2 and varargs[0] = 2? Don't we need to fallback to numpy in this case?
| @pytest.mark.parametrize("array", [[2, 3, 6, 8, 4, 9], | ||
| [3., 4., 7.5, 9.], | ||
| [2, 6, 8, 10]]) | ||
| def test_gradient_y1(self, array): |
There was a problem hiding this comment.
Both tests are named the same.
densmirn
approved these changes
Jan 19, 2021
densmirn
reviewed
Jan 19, 2021
|
|
||
| result._setitem_scalar(size - 1, cur) | ||
|
|
||
| for i in range(1, len - 1): |
There was a problem hiding this comment.
Suggested change
| for i in range(1, len - 1): | |
| for i in range(1, size-1): |
|
Could you please rebase on master? |
shssf
approved these changes
Jan 21, 2021
|
error in tests: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.