REFACTOR: random module, backend lib #524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shssf
reviewed
Jan 23, 2021
shssf
reviewed
Jan 23, 2021
| * @brief math library implementation of random number generator (multinomial distribution) | ||
| * | ||
| * @param [in] size Number of elements in `result` arrays. | ||
| * |
There was a problem hiding this comment.
do we need this empty line? Perhaps it is better to remove all these lines from "doctrings" in this file to make it a bit more compact.
There was a problem hiding this comment.
not sure how it will look in documentation
There was a problem hiding this comment.
@shssf I have checked, you are right. We need refactor this also, see: https://mesos.readthedocs.io/en/latest/doxygen-style-guide/.
We just need to do the same for dpnp_iface.hpp. Will do it on other PR.
There was a problem hiding this comment.
👍 nice article.
Please, let's do it step by step. First step inside rng only
shssf
approved these changes
Jan 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dpnp_srand- >dpnp_rng_sranddpnp_*todpnp_rng_*dpnp_iface_random.hpp