FULL add kernel #558
FULL add kernel #558
Conversation
|
I think that there is a more common solution for functions like |
Almost, except that |
| @@ -84,6 +85,28 @@ cpdef dparray dpnp_diag(v, k): | |||
| return result | |||
|
|
|||
|
|
|||
| cpdef dparray dpnp_full(result_shape, value_in, result_dtype): | |||
| """ Convert string type names (dparray.dtype) to C enum DPNPFuncType """ | |||
There was a problem hiding this comment.
| """ Convert string type names (dparray.dtype) to C enum DPNPFuncType """ | |
| # Convert string type names (dparray.dtype) to C enum DPNPFuncType |
Please use comment sign for comments otherwise Cython converts this to strings from src.
dpnp/dpnp_iface_arraycreation.py
Outdated
|
|
||
| _dtype = dtype if dtype is not None else type(fill_value) | ||
| if not use_origin_backend(): | ||
| if order != 'C': |
There was a problem hiding this comment.
| if order != 'C': | |
| if order is not 'C': |
There was a problem hiding this comment.
Generally strings in Python are compared by value, not identity. I have one example which shows a potential issue:
a = 'hi'
b = ''.join(['h', 'i'])
a == b # True
a is b # False
There was a problem hiding this comment.
@densmirn in this PR you also moving some functional code (without changing) from one src to another, for future please do this kind of refactoring on separate PRs. PR must have one logic.
No description provided.