Support array-scalar operations for 10 more funcs #648
Conversation
| { \ | ||
| const _DataType input_elem1 = (size1 == 1) ? array1[0] : array1[i]; \ | ||
| const _DataType input_elem2 = (size2 == 1) ? array2[0] : array2[i]; \ | ||
| const _DataType input_elem1 = (input1_size == 1) ? input1[0] : input1[i]; \ | ||
| const _DataType input_elem2 = (input2_size == 1) ? input2[0] : input2[i]; \ | ||
| result[i] = __operation__; \ | ||
| } \ |
There was a problem hiding this comment.
You don't need this extra braces here.
| ctypedef void(*fptr_1in_1out_t)(void *, void *, size_t) | ||
| ctypedef void(*fptr_2in_1out_t)(void *, void *, void *, size_t) | ||
| # to be fused with fptr_2in_1out_t | ||
| ctypedef void(*fptr_2in_1out_new_t)(void *, const void *, const size_t, const long *, const size_t, |
There was a problem hiding this comment.
Do I understand correctly that this func point name fptr_2in_1out_new_t is temporary?
And in the future, you will delete the current fptr_2in_1out_t and rename fptr_2in_1out_new_t to fptr_2in_1out_t?
If not it is better rename fptr_2in_1out_new_t.
new word may confuse.
There was a problem hiding this comment.
You are right. fptr_2in_1out_new_t will be renamed to fptr_2in_1out_t in further.
| cdef dparray call_fptr_2in_1out(DPNPFuncName fptr_name, dparray x1, dparray x2, dparray_shape_type result_shape, new_version=False): | ||
| cdef dparray call_fptr_2in_1out(DPNPFuncName fptr_name, object x1_obj, object x2_obj, | ||
| object dtype=None, dparray out=None, object where=True, | ||
| bint new_version=False): |
There was a problem hiding this comment.
better to add a comment here in case this param will be removed in the future.
There was a problem hiding this comment.
dpnp/dpnp/dpnp_algo/dpnp_algo.pyx
Line 381 in bd42068
No description provided.