Wheel changes to master #654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Vyacheslav-Smirnov
commented
Mar 19, 2021
Vyacheslav-Smirnov
commented
- Update README
- Set RPATH to dpctl and dpnp itself
- Fix in setup.py
Gold/2021 update 0 5 1
* Update packages wheel deps * Do not search deps via setuptools * Fix build: no search for dpes via setuptools * Add set -ex to build.sh * Revert changes to meta.yaml, build.sh and install_requires in setup.py * Remove author_email * Add correct license description * Add How to for install dpnp wheel package * Add RPATH for wheels; update readme
shssf
reviewed
Mar 19, 2021
| @@ -25,6 +25,10 @@ if [ -n "${TBBROOT}" ]; then | |||
| . ${TBBROOT}/env/vars.sh | |||
| fi | |||
|
|
|||
| # Set RPATH for wheels | |||
| export CFLAGS="-Wl,-rpath,\$ORIGIN/../dpctl,-rpath,\$ORIGIN $CFLAGS" | |||
There was a problem hiding this comment.
How it will work in Windows?
There was a problem hiding this comment.
The "build.sh" file is used only for unix build. For windows there should be bld.bat with build commands.
As there is no bld.bat file, windows build now is just fake)
shssf
reviewed
Mar 19, 2021
| maintainer="Intel Corp.", | ||
| maintainer_email="scripting@intel.com", | ||
| url="https://intelpython.github.io/dpnp/", | ||
| download_url="https://github.com/IntelPython/dpnp", | ||
| license=__license_file__, | ||
| license='BSD', |
There was a problem hiding this comment.
Is this change related to "wheel testing"?
There was a problem hiding this comment.
Yes, changing setup.py format is required to build a good wheel which can be uploaded to Pypi
…/dpnp into wheel_changes_master
|
@shssf , Are you ok with the changes? |
|
Will be merged in scope of #657 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.