add kernel for max with axis #698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| axis_.reserve(len(axis)) | ||
| for shape_it in axis: | ||
| if shape_it < 0: | ||
| raise ValueError("DPNP dparray::__init__(): Negative values in 'shape' are not allowed") |
There was a problem hiding this comment.
avoid raising error on cython level. Move this, please, on python level.
shssf
reviewed
May 10, 2021
| @@ -301,8 +301,28 @@ def max(input, axis=None, out=None, keepdims=numpy._NoValue, initial=numpy._NoVa | |||
| """ | |||
|
|
|||
| if not use_origin_backend(input): | |||
| isaxis = True | |||
There was a problem hiding this comment.
What cases you are trying to handle here? Is it a code to validate axis as input?
It would be better to write small comment in the code about it.
If it a user input validation procedure - it is better to put it in some "utils" place. Perhaps it is already where.
There was a problem hiding this comment.
@shssf
DPNP dparray::init(): Negative values in 'shape' are not allowed
To avoid causing this error at the Cython level, this check has been added. The error call removal was requested in the PR above.
shssf
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.