add broadcasting for remainder func #714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| cl::sycl::range<1> gws(result_size); | ||
| auto kernel_parallel_for_func = [=](cl::sycl::id<1> global_id) { | ||
| const size_t i = global_id[0]; /* for (size_t i = 0; i < result_size; ++i) */ |
There was a problem hiding this comment.
Suggested change
| const size_t i = global_id[0]; /* for (size_t i = 0; i < result_size; ++i) */ | |
| const size_t i = global_id[0]; |
| std::is_same<_DataType_input2, _DataType_input1>::value) | ||
| { | ||
| event = oneapi::mkl::vm::fmod(DPNP_QUEUE, input1_size, input1_data, input2_data, result); | ||
| event.wait(); |
There was a problem hiding this comment.
use dependent event. Do not wait for each.
There was a problem hiding this comment.
use dependent event. Do not wait for each.
| const size_t i = global_id[0]; /* for (size_t i = 0; i < result_size; ++i) */ | ||
| const _DataType_output input1_elem = (*input1_it)[i]; | ||
| const _DataType_output input2_elem = (*input2_it)[i]; | ||
| double fmod = cl::sycl::fmod((double)input1_elem, (double)input2_elem); |
There was a problem hiding this comment.
please, use another name for fmod variable to avoid potential naming collision/ naming conflicts.
|
|
||
| DPNPC_id<_DataType_input1>* input1_it; | ||
| const size_t input1_it_size_in_bytes = sizeof(DPNPC_id<_DataType_input1>); | ||
| input1_it = reinterpret_cast<DPNPC_id<_DataType_input1>*>(dpnp_memory_alloc_c(input1_it_size_in_bytes)); |
There was a problem hiding this comment.
You can call mem allocator at once here.
| std::is_same<_DataType_input2, _DataType_input1>::value) | ||
| { | ||
| event = oneapi::mkl::vm::fmod(DPNP_QUEUE, input1_size, input1_data, input2_data, result); | ||
| event.wait(); |
There was a problem hiding this comment.
use dependent event. Do not wait for each.
Comment on lines
+420
to
+421
| input1_it->~DPNPC_id(); | ||
| input2_it->~DPNPC_id(); |
There was a problem hiding this comment.
It seems that we need to redesign this class, if explicitly call of the destructor is required for its interface.
shssf
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.