support parameter out for matmul func #722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpnp/dpnp_algo/dpnp_algo.pyx
Outdated
Comment on lines
242
to
248
| if out is not None: | ||
| if out.dtype != result_type: | ||
| raise TypeError("Inappropriate type of ``out`` variable") | ||
| elif out.shape != shape_result: | ||
| raise ValueError("Inappropriate shape of ``out`` variable") | ||
| else: | ||
| result = out |
There was a problem hiding this comment.
Do not raise error here.
It is better move this on python level and make this as fallback condition.
densmirn
reviewed
May 24, 2021
dpnp/dpnp_algo/dpnp_algo.pyx
Outdated
Comment on lines
243
to
246
| if out.dtype != result_type: | ||
| raise TypeError("Inappropriate type of ``out`` variable") | ||
| elif out.shape != shape_result: | ||
| raise ValueError("Inappropriate shape of ``out`` variable") |
There was a problem hiding this comment.
I would use checker_throw_value_error in these cases, e.g.:
checker_throw_value_error('matmul', 'out.dtype', out.dtype, result_type)
There was a problem hiding this comment.
You could replace elif with if and remove line with else.
There was a problem hiding this comment.
No error raising on cython layer.
There was a problem hiding this comment.
We don't know result_type in python level.
densmirn
approved these changes
May 25, 2021
Comment on lines
+243
to
+246
| if out.dtype != result_type: | ||
| checker_throw_value_error('matmul', 'out.dtype', out.dtype, result_type) | ||
| if out.shape != shape_result: | ||
| checker_throw_value_error('matmul', 'out.shape', out.shape, shape_result) |
There was a problem hiding this comment.
This will not work. Avoid using this kind of error throwing. It is better avoiding error raising in cython level. redesign is needed.
shssf
approved these changes
Jun 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.