Skip to content

Conversation

samir-nasibli
Copy link

No description provided.

@samir-nasibli samir-nasibli added the in progress Please do not merge. Work is in progress. label Jun 28, 2021

for (size_t i = 0; i < iters; ++i)
{
dpnp_rng_srand_c(seed);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you need to set the same initial value at any loop iteration?

* Example 10.
*
* Possible compile line:
* clang++ -fPIC -fsycl dpnp/backend/examples/example10.cpp -Idpnp -Idpnp/backend/include -Ldpnp -Wl,-rpath='$ORIGIN'/dpnp -ldpnp_backend_c -o example10 -lmkl_sycl -lmkl_intel_ilp64 -lmkl_core
Copy link
Contributor

@shssf shssf Jun 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect you don't have to set -fsycl here. in this case, it might be a regular gcc as a compiler
No need -fPIC because it is not a library (*.so)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #754 for details

@shssf
Copy link
Contributor

shssf commented Jul 6, 2021

Please remove the "in progress" label when this PR is ready to be merged.

@samir-nasibli samir-nasibli removed the in progress Please do not merge. Work is in progress. label Jul 12, 2021
@samir-nasibli
Copy link
Author

Please remove the "in progress" label when this PR is ready to be merged.

@shssf This PR is ready to merge.

@shssf shssf merged commit 2ae0153 into master Jul 12, 2021
@shssf shssf deleted the samir-nasibli/example/wxample10 branch July 12, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants