bool dtype support, all and any functions
#77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
==========================================
- Coverage 52.48% 52.03% -0.45%
==========================================
Files 19 19
Lines 1147 1178 +31
Branches 295 305 +10
==========================================
+ Hits 602 613 +11
- Misses 310 320 +10
- Partials 235 245 +10
Continue to review full report at Codecov.
|
densmirn
approved these changes
Sep 28, 2020
densmirn
reviewed
Sep 28, 2020
Comment on lines
+130
to
+135
| if axis is not None: | ||
| checker_throw_value_error("all", "axis", type(axis), None) | ||
| if out is not None: | ||
| checker_throw_value_error("all", "out", type(out), None) | ||
| if keepdims is not False: | ||
| checker_throw_value_error("all", "keepdims", keepdims, False) |
There was a problem hiding this comment.
You could give the original numpy a chance to deal with these cases.
Alexander-Makaryev
changed the title
all and any functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.