ENH: dpnp.histogram fallback; tests
#802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shssf
reviewed
Jul 30, 2021
dpnp/dpnp_iface_histograms.py
Outdated
| ] | ||
|
|
||
|
|
||
| def histogram(a, bins=10, range=None, normed=None, weights=None, density=None): |
There was a problem hiding this comment.
Could you please move this code into dpnp_iface_statistics.py?
There was a problem hiding this comment.
Logically and due the the numpy's division by modules histogram should not be in dpnp_iface_statistics.py.
However, if it's required I will add it there.
shssf
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dpnp.histogramTests
tests/test_histograms.py, while we have issue with numpy testsing