No need to have a separate loop for log2 umath
#109
Merged
+4
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
requested review from
ndgrigorian,
xaleryb and
ekomarova
as code owners
antonwolfy
force-pushed
the
remove-dedicated-log2-loop
branch
from
183db68 to
e421b78
Compare
|
This PR fixes all the test issues except for |
|
@ndgrigorian, please review |
That would be covered by #110 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR aligns
log2implementation with numpy, where there is no dedicated loop forlog2umath (see here). Also there is no clearing the floating point status, it seems not needed.