Skip to content

Conversation

PokhodenkoSA
Copy link
Contributor

Convert examples style tests to unittest.

@PokhodenkoSA PokhodenkoSA merged commit f4333dd into spokhode/dparray Dec 15, 2020
import sys
import unittest

from numba_dppy.testing import DPPYTestCase
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use DPPYTestCase anymore.
Use unittest.TestCase instead

Copy link
Contributor

@DrTodd13 DrTodd13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks fine with my previous comment that the USM to numpy implicit conversion test should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Related to test suite or test run infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants