-
Notifications
You must be signed in to change notification settings - Fork 32
Apply builder pattern to kernel launcher #1243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply builder pattern to kernel launcher #1243
Conversation
12dbc5a
to
439b5f9
Compare
439b5f9
to
3be676b
Compare
Few dead code that I noticed after your changes in
|
3be676b
to
b8321fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice clean up. Makes the code readable and reduces redundancies.
@@ -11,6 +17,48 @@ | |||
from numba_dpex.dpctl_iface import libsyclinterface_bindings as sycl | |||
from numba_dpex.dpctl_iface._helpers import numba_type_to_dpctl_typenum | |||
|
|||
MAX_SIZE_OF_SYCL_RANGE = 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a place in parfor_lowerer.py
where the same hard coing is done. It will be goo to move the global to dpctl_iface
and use it from there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I've already removed it from parfor_lowerer. This constant is beeing used there through the set_range()
call.
There is an issue in this change. Before this change parfor_lowerer was using |
d00701f
to
7d1f4b8
Compare
7d1f4b8
to
649ca87
Compare
…rn_to_kernel_launcher Apply builder pattern to kernel launcher 2d6ddb8
…ilder_pattern_to_kernel_launcher Apply builder pattern to kernel launcher 2d6ddb8
Update kernel launcher builder to use builder pattern. Since the argument list is long we need modular way of providing those arguments to make code more readable and extendable.