Skip to content

black formatter #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 23, 2020
Merged

black formatter #135

merged 5 commits into from
Dec 23, 2020

Conversation

PokhodenkoSA
Copy link
Contributor

@PokhodenkoSA PokhodenkoSA commented Dec 21, 2020 •
edited
Loading

Closes #129

Examples: IntelPython/dpctl#91

black is "The Uncompromising Code Formatter".

  • Use the black badge in project's README.md for indicating the code style
  • Add GitHub Actions for black for check code style
  • Ignore versioneer.py because it is 3rd party file (see pyproject.toml)
  • Update CONTRIBUTING.md for all developers to use black in everyday work
  • Format all Python code with black (just black .)
  • Add ignoring revisions in blame so you can see meaningful blame info after global formatting commit

Usage is simple: black .

diptorupd
diptorupd approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally black is here!

@PokhodenkoSA PokhodenkoSA mentioned this pull request Dec 22, 2020
Merged
3 tasks
@PokhodenkoSA PokhodenkoSA merged commit 8bd62e6 into main Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@diptorupd diptorupd diptorupd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@PokhodenkoSA PokhodenkoSA

Labels

infrastructure

Projects

None yet

Milestone

0.13.0

Development

Successfully merging this pull request may close these issues.

Black formatter

2 participants

@PokhodenkoSA @diptorupd