Add setup.py and conda-recipe #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is initial draft version.
Now numba.dppl is placed in separate package numba_dppy.
Previousply it was `from numba import dppl`. Now it is `import numba_dppy as dppl`.
There are many places in code which access to `numba_dppy`. Previously it was `numba.dppl`. It was accessible because `from numba import dppl`.
This parameters are necessary for PyPI.
`dispatcher_registry.ondemand['dppl'] = init_jit` can be used only one time. So `dppl` was renamed to `dppy`. Also in class TargetDispatcher field `target_dppl = 'dppl'` renamed to `dppy`.
This flag configure installation of `numba_dppy` as folder in `site-packages`. The folder is required for installing compiled spirv code to it.
PokhodenkoSA
commented
Nov 16, 2020
Comment on lines
+14
to
+16
| %CC% -flto -target spir64-unknown-unknown -c -x cl -emit-llvm -cl-std=CL2.0 -Xclang -finclude-default-header numba_dppy/ocl/atomics/atomic_ops.cl -o numba_dppy/ocl/atomics/atomic_ops.bc | ||
| llvm-spirv -o numba_dppy/ocl/atomics/atomic_ops.spir numba_dppy/ocl/atomics/atomic_ops.bc | ||
| xcopy numba_dppy\ocl\atomics\atomic_ops.spir %SP_DIR%\numba_dppy\ocl\atomics /E /Y |
There was a problem hiding this comment.
Move SPIRV compilation to setup.py.
There was a problem hiding this comment.
Related to IntelPython/numba#110
PokhodenkoSA
commented
Nov 16, 2020
| - dpctl | ||
| - spirv-tools | ||
| - llvm-spirv | ||
| - dpnp |
There was a problem hiding this comment.
dpNP is optional dependency
PokhodenkoSA
commented
Nov 16, 2020
| --------------------------------------------------------------------------- | ||
| import numpy as np | ||
| from numba import dppl | ||
| import numba_dppy, numba_dppy as dppl |
There was a problem hiding this comment.
Rename dppl to dppy.
PokhodenkoSA
commented
Nov 16, 2020
|
|
||
| metadata = dict( | ||
| name="numba-dppy", | ||
| version="0.0.1", |
There was a problem hiding this comment.
Use versioneer.py
This was referenced Nov 16, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now with setup.py it is possible to install and run tests. Via tests I have faced with many access to
numba.dppl.This PR also replaces access like
numba.dppltonumba_dppy.Some code uses
@dppl.kernel. For this casesimport numba_dppy as dppl. It could be renamed todppyin separate PR.Now tests passed (should recheck on clean numba). Commands:
Related to:
numba-dppynumba#109numba-dppynumba#110