Skip to content

Conversation

diptorupd
Copy link
Contributor

Use a consistent black formatting style across dpctl and numba-dppy.

@diptorupd
Copy link
Contributor Author

The changes need to be merged and not squashed.

@PokhodenkoSA
Copy link
Contributor

@diptorupd please move coverage changes to separate PR.
About line width - OK. But now is not a good time for this. CI does not work. As I understand you made it automatically. Could you please repeat it later when CI will work again?

@diptorupd
Copy link
Contributor Author

@diptorupd please move coverage changes to separate PR. About line width - OK. But now is not a good time for this. CI does not work. As I understand you made it automatically. Could you please repeat it later when CI will work again?

I can move out the coverage changes to a separate PR, but is just more overhead. As you can see, I want to merge the PR that will preserve the coverage changes as a separate commit.

I do not follow your argument about the CI. Why should a formatting change have anything to do with CI? Moreover, I can see that the public jobs ran successfully. If we wait for internal CI, then unfortunately we have to stop developing and that is unacceptable to me.

@diptorupd
Copy link
Contributor Author

I am closing the PR for now. Instead of doing the refactoring for code improvements in this manner, I have decided to develop the changes in my own branch on my fork. It helps me as the changes are incremental and one on top of the other. Once CI is back, I will take the individual commits from my branch and open PRs.

@diptorupd diptorupd closed this Nov 13, 2021
@diptorupd diptorupd deleted the refactor/code-style branch November 13, 2021 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants