Skip to content

Missing values support for inference #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

razdoburdin
Copy link
Collaborator

This PR is related to missing values support in oneDAL and scikit-learn-intelex. As far as support of missing values will be added by the mentioned PRs, checking in benchmarks should be removed.

@razdoburdin razdoburdin requested a review from Alexsandruss as a code owner May 9, 2023 11:14
Copy link

@samir-nasibli samir-nasibli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Did we fully validate this changes?

@razdoburdin
Copy link
Collaborator Author

LGTM. Did we fully validate this changes?

Yes. I made the tests.
This PR cancel the changes by #127, since missing values are now supported.

@samir-nasibli samir-nasibli merged commit 9445f39 into IntelPython:master Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants