Skip to content

Update solver in PCA config #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2024
Merged

Update solver in PCA config #155

merged 1 commit into from
Aug 30, 2024

Conversation

Alexsandruss
Copy link
Contributor

Update svd_solver=covariance_eigh in PCA config to reflect sklearn 1.5 and related sklearnex patching changes.

Remove sklearn<1.5 limitation.

icfaust
icfaust approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@icfaust icfaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable changes.

@Alexsandruss Alexsandruss merged commit 328fcaf into IntelPython:main Aug 30, 2024
15 checks passed
This was referenced Sep 26, 2024
Merged
Merged
@homksei homksei mentioned this pull request Sep 30, 2024
Merged
8 tasks
@Alexandr-Solovev Alexandr-Solovev mentioned this pull request Oct 1, 2024
Merged
2 tasks
@ethanglaser ethanglaser mentioned this pull request Oct 1, 2024
Merged
13 tasks
@Alexandr-Solovev Alexandr-Solovev mentioned this pull request Oct 2, 2024
Closed
13 tasks
@samir-nasibli samir-nasibli mentioned this pull request Oct 2, 2024
Merged
13 tasks
This was referenced Oct 2, 2024
Merged
Merged
@md-shafiul-alam md-shafiul-alam mentioned this pull request Oct 8, 2024
Closed
13 tasks
@samir-nasibli samir-nasibli mentioned this pull request Oct 10, 2024
Closed
13 tasks
@icfaust icfaust mentioned this pull request Oct 15, 2024
Merged
13 tasks
@olegkkruglov olegkkruglov mentioned this pull request Oct 15, 2024
Merged
13 tasks
@Alexandr-Solovev Alexandr-Solovev mentioned this pull request Oct 16, 2024
Merged
12 tasks
@Vika-F Vika-F mentioned this pull request Oct 22, 2024
Draft
13 tasks
@Alexandr-Solovev Alexandr-Solovev mentioned this pull request Oct 22, 2024
Merged
3 tasks
This was referenced Oct 23, 2024
Merged
Merged
@Alexandr-Solovev Alexandr-Solovev mentioned this pull request Oct 24, 2024
Closed
13 tasks
@Alexsandruss Alexsandruss mentioned this pull request Oct 25, 2024
Merged
13 tasks
@ethanglaser ethanglaser mentioned this pull request Oct 29, 2024
Merged
13 tasks
@Alexandr-Solovev Alexandr-Solovev mentioned this pull request Oct 29, 2024
Closed
13 tasks
@icfaust icfaust mentioned this pull request Oct 31, 2024
Merged
13 tasks
This was referenced Oct 31, 2024
Merged
Merged
@icfaust icfaust mentioned this pull request Jun 17, 2025
Merged
13 tasks
@ethanglaser ethanglaser mentioned this pull request Jun 17, 2025
Draft
13 tasks
@Vika-F Vika-F mentioned this pull request Jun 18, 2025
Merged
8 tasks
@yuejiaointel yuejiaointel mentioned this pull request Jun 25, 2025
Closed
13 tasks
@Vika-F Vika-F mentioned this pull request Jun 25, 2025
Closed
13 tasks
@Alexandr-Solovev Alexandr-Solovev mentioned this pull request Jun 30, 2025
Closed
13 tasks
@Vika-F Vika-F mentioned this pull request Jun 30, 2025
Closed
6 tasks
@Alexandr-Solovev Alexandr-Solovev mentioned this pull request Jul 2, 2025
Merged
13 tasks
@Vika-F Vika-F mentioned this pull request Jul 4, 2025
Merged
7 tasks
This was referenced Jul 7, 2025
Merged
Merged
@antonio-decaro antonio-decaro mentioned this pull request Jul 9, 2025
Draft
13 tasks
@Alexandr-Solovev Alexandr-Solovev mentioned this pull request Jul 11, 2025
Merged
13 tasks
@Vika-F Vika-F mentioned this pull request Jul 15, 2025
Merged
6 tasks
@ethanglaser ethanglaser mentioned this pull request Jul 15, 2025
Merged
13 tasks
@david-cortes-intel david-cortes-intel mentioned this pull request Jul 16, 2025
Closed
13 tasks
@ethanglaser ethanglaser mentioned this pull request Jul 16, 2025
Merged
13 tasks
This was referenced Jul 21, 2025
Closed
Merged
@ethanglaser ethanglaser mentioned this pull request Jul 21, 2025
Closed
13 tasks
@Vika-F Vika-F mentioned this pull request Jul 22, 2025
Closed
13 tasks
This was referenced Jul 23, 2025
Closed
Merged
@Vika-F Vika-F mentioned this pull request Jul 25, 2025
Open
9 tasks
@icfaust icfaust mentioned this pull request Jul 30, 2025
Merged
13 tasks
@Alexandr-Solovev Alexandr-Solovev mentioned this pull request Jul 31, 2025
Merged
13 tasks
@david-cortes-intel david-cortes-intel mentioned this pull request Aug 1, 2025
Merged
6 tasks
This was referenced Aug 18, 2025
Draft
Merged
@Alexandr-Solovev Alexandr-Solovev mentioned this pull request Aug 26, 2025
Draft
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icfaust icfaust icfaust approved these changes

@ethanglaser ethanglaser Awaiting requested review from ethanglaser ethanglaser is a code owner

+1 more reviewer

@md-shafiul-alam md-shafiul-alam md-shafiul-alam approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alexsandruss @icfaust @md-shafiul-alam