Update README.md #29
Merged
Update README.md #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PivovarA
commented
Jun 11, 2020
PivovarA
commented
- Add frameworks list
- Add algorithms list
- Add algorithms parameters
- Add description of configuration file
|
Great work!👍 |
remove Config JSON Schema paragraph change main description of repository apply minor text changes
outoftardis
suggested changes
Jul 14, 2020
There was a problem hiding this comment.
Note: I haven't reviewed everything.
What you have to change:
- make sure that the first word in each sell in each table starts with a capital letter (this does not apply to the cells that start with parameter names, type names, and similar info)
- if you have a full sentence in a table sell, make sure it and everything else in the same column ends with the full stop
. - when you describe a parameter, instead of "Number of" you have to say "The number of", instead of "Path to" -- "The path to"
Co-authored-by: Ekaterina Mekhnetsova <outoftardis@users.noreply.github.com>
Co-authored-by: Ekaterina Mekhnetsova <outoftardis@users.noreply.github.com>
Apply all suggestions Co-authored-by: Ekaterina Mekhnetsova <outoftardis@users.noreply.github.com>
PetrovKP
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.