-
Notifications
You must be signed in to change notification settings - Fork 62
Building with Intel(R) distribution for python and boost regex #26
Conversation
fschlimb
commented
Apr 30, 2018
- simplifying building parquet extension
- fixing arguments to setuptools extension specs
- adding unit test for regex
- using boost regex
pq_libs += ['arrow', 'parquet'] | ||
else: | ||
# seperate parquet reader used due to ABI incompatibility of arrow | ||
pq_libs += ['hpat_parquet_reader'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we remove hpat_parquet_reader as a separate package, we can't build HPAT with default Anaconda environment anymore. Can we have both default Anaconda and Intel builds? maybe if macros?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens with anaconda?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anaconda is not compatible with conda-forge (we use parquet/arrow) because of compiler version differences (gcc 7.2 vs 4.8). hpat_parquet_reader provides a C interface (without std::string) to avoid the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the bigger problem is boost, which we use from conda-forge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's easier to go around boost problems.
|
||
setup(name='hpat', | ||
version='0.2.0', | ||
version='0.3.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should figure out our versioning policy.
- h5py | ||
- daal-devel | ||
- opencv 3.3.1 | ||
- hpat-parquet-reader # [not win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need hpat-parquet-reader for building with default Anaconda.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
- mpich # [not win] | ||
- pyarrow 0.9.* | ||
- boost | ||
- boost-cpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the difference of boost and boost-cpp?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
boost is a meta package from anconda, which depends on libboost and boost-py (or so). The conda-forge naming is different. The arrow packages we use from conda-forge use the ones from conda-forge. anaconda is behind with the version, we cannot mix.
Closing in favor of #27. |