This repository was archived by the owner on Feb 2, 2024. It is now read-only.
Make PyArrow cpu_count to correspond NUMBA_NUM_THREADS #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardcode84
reviewed
Nov 28, 2019
densmirn
reviewed
Nov 29, 2019
densmirn
reviewed
Nov 29, 2019
densmirn
reviewed
Dec 3, 2019
|
Hello @PokhodenkoSA! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2019-12-11 08:00:26 UTC |
densmirn
reviewed
Dec 3, 2019
|
This PR looks very big. I will split it to many smaller ones with dedicated improvements. Now I am using the PR for preparing benchmark report only. |
Add pyarrow_cpu_count context manager which always returns cpu_count to previous value.
Use single config data in all places Add PyArrow benchmark record read_csv data size (1m,10) Show size [rows,cols] Implement data file caching and move functions for generating to gen_csv.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes PyArrow treads count equal to Numba threads count.
I do not know which threading layer is used by PyArrow. it is possible that there is no intersection with Numba layers.
By default PyArrow uses all available cpus for reading.