This repository was archived by the owner on Feb 2, 2024. It is now read-only.
Add sdc_overload, sdc_overload_method, sdc_overload_attribute decorators #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please do the same for |
Hardcode84
force-pushed
the
sdc_overload_method
branch
from
389d101 to
c3c4af9
Compare
|
Hello @Hardcode84! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-12-11 10:44:12 UTC |
Hardcode84
force-pushed
the
sdc_overload_method
branch
from
632a33f to
edc9e89
Compare
Hardcode84
changed the title
AlexanderKalistratov
approved these changes
Dec 11, 2019
Hardcode84
force-pushed
the
sdc_overload_method
branch
from
edc9e89 to
05e3d6a
Compare
Hardcode84
force-pushed
the
sdc_overload_method
branch
from
05e3d6a to
32bdc37
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will need to add
inline='always'(and possible other attributes) to all our@overload_methods after numba@overload_methodrefactoring merge. Add our own attribute wrapper so it can be made from one place.