This repository was archived by the owner on Feb 2, 2024. It is now read-only.
Implement Series.str.find() #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if not isinstance(sub, (StringLiteral, UnicodeType)): | ||
| ty_checker.raise_exc(sub, 'str', 'sub') | ||
|
|
||
| accepted_types = (Integer, IntegerLiteral, NoneType, Omitted) |
There was a problem hiding this comment.
If I'm not mistaken IntegerLiteral is inherited from Integer, so just (Integer, NoneType, Omitted) would be enough. But it is better to check
There was a problem hiding this comment.
Also I'm not sure if it is better to explicitly add IntegerLiteral as supported type or not. On one hand it makes the code more clear, on another, it is confusing that in some places it is specified and in another is not.
There was a problem hiding this comment.
You are right. IntegerLiteral is inherited of Integer.
| ty_checker.raise_exc(end, 'None, int', 'end') | ||
|
|
||
| def hpat_pandas_stringmethods_find_impl(self, sub, start=0, end=None): | ||
| if start != 0: |
There was a problem hiding this comment.
Why we are not supporting start and end? UnicodeString doesn't?
There was a problem hiding this comment.
Numba 0.46 doesn't support str.find with extra parameters.
IntegerLiteral is inherited of Integer
densmirn
force-pushed
the
feature/str_find
branch
from
78894d0 to
99f8f84
Compare
AlexanderKalistratov
added
FullyApproved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.