Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

Conversation

densmirn
Copy link
Contributor

@densmirn densmirn commented Dec 9, 2019

No description provided.

@densmirn densmirn changed the title Feature/str just Implement Series.str.ljust()/rjust() Dec 9, 2019
Copy link
Collaborator

@AlexanderKalistratov AlexanderKalistratov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we really should create new file for each sample. Probably similar functionality into single file? Or create folder which unites all str methods?

@AlexanderKalistratov AlexanderKalistratov added FullyApproved Mark PR if all required approval exists and removed Ready for Review labels Dec 9, 2019
@densmirn
Copy link
Contributor Author

I'm not sure if we really should create new file for each sample. Probably similar functionality into single file? Or create folder which unites all str methods?

We should have separate documentation for each functionality. So I think we need to have separated examples, but I agree to put the examples in separate folders.

@densmirn densmirn merged commit bdcfe14 into IntelPython:master Dec 10, 2019
@densmirn densmirn deleted the feature/str_just branch June 9, 2020 12:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

FullyApproved Mark PR if all required approval exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants