This repository was archived by the owner on Feb 2, 2024. It is now read-only.
change isinstance #792
Merged
change isinstance #792
+16
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
densmirn
reviewed
Apr 1, 2020
densmirn
reviewed
Apr 1, 2020
| @@ -1995,16 +1995,16 @@ def pct_change_overload(df, periods=1, fill_method='pad', limit=None, freq=None) | |||
| ty_checker = TypeChecker('Method {}().'.format(name)) | |||
| ty_checker.check(df, DataFrameType) | |||
|
|
|||
| if not isinstance(periods, (types.Integer, types.Omitted)): | |||
| if not isinstance(periods, (types.Integer, types.Omitted)) and periods != 1: | |||
There was a problem hiding this comment.
Why periods could not be equal to other values?
There was a problem hiding this comment.
@densmirn periods could be equal to other values. This condition need that default value supported.
Comment on lines
+2004
to
+2007
| if not isinstance(limit, (types.Omitted, types.NoneType)) and limit is not None: | ||
| ty_checker.raise_exc(limit, 'None', 'limit') | ||
|
|
||
| if not isinstance(freq, (types.Omitted, types.NoneType)): | ||
| if not isinstance(freq, (types.Omitted, types.NoneType)) and freq is not None: |
There was a problem hiding this comment.
Please add unit test on situation when limit and freq are equal to None on the typing stage. Pay your attention that there are no such checks in Series.pct_change overload.
densmirn
reviewed
Apr 1, 2020
| @@ -1954,7 +1954,7 @@ def pct_change_overload(df, periods=1, fill_method='pad', limit=None, freq=None) | |||
|
|
|||
| Limitations | |||
| ----------- | |||
| Parameters ``limit`` and ``freq`` are unsupported. | |||
| Parameters ``limit`` and ``freq`` are supported. | |||
There was a problem hiding this comment.
This statement doesn't look like a limitation.
densmirn
approved these changes
Apr 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.