Package into a Docker image #1
Conversation
README.md
Outdated
| # Docker OAuth2 Proxy | ||
|
|
||
| This is a small docker image for `oauth2_proxy` which is a reverse proxy | ||
| that provides authentication with Google, Github or other providers. |
There was a problem hiding this comment.
Casing here of Github should be GitHub.
|
|
||
| Get a `bash` shell from the container | ||
|
|
||
| $ docker run zappi/oauth2_proxy --version |
There was a problem hiding this comment.
This doesn't get us a bash shell.
| tagged: | ||
| tag: /.*/ | ||
| commands: | ||
| - docker login -e $DOCKER_EMAIL -u $DOCKER_USER -p $DOCKER_PASS |
There was a problem hiding this comment.
Will these environment variables be set up as secrets in Circle CI?
There was a problem hiding this comment.
I dunno. 😰
I'm also wondering who's details should I use.
| commands: | ||
| - docker login -e $DOCKER_EMAIL -u $DOCKER_USER -p $DOCKER_PASS | ||
| - docker tag $IMAGE_NAME:latest $IMAGE_NAME:$CIRCLE_TAG | ||
| - docker push $IMAGE_NAME:$CIRCLE_TAG |
There was a problem hiding this comment.
Does this also push the latest tag?
There was a problem hiding this comment.
Ah I see you've added it in another commit. Can they not be pushed together?
There was a problem hiding this comment.
I could but I'm not sure it works i.e. does it overwrite? will it error out due to a conflict like ECR?
There was a problem hiding this comment.
In that case I'd like to revert just that specific change.
There was a problem hiding this comment.
I think let's just have it push the Git tag and see what happens first?
There was a problem hiding this comment.
I think let's just have it push the Git tag and see what happens first?
Dropped latest push for now. We can do it later.
circle.yml
Outdated
There was a problem hiding this comment.
Not necessary to put :latest here.
There was a problem hiding this comment.
Yes, this is how we tag in deploy.sh:
docker tag $IMAGE_NAME $AWS_ACCOUNT_ID.dkr.ecr.$AWS_REGION.amazonaws.com/$IMAGE_NAME:$VERSION
There was a problem hiding this comment.
Done in 7619ae6. However, it would have still worked. Docker defaults to latest when no tag set.
2 participants
Package v2.1 with Alpine 3.4 base image and configure tests and automatic builds.