Skip to content

Conversation

zacblazic
Copy link
Member

As per the title.

Dockerfile Outdated
cp /var/tmp/oauth2_proxy/${OAUTH2_PROXY_PKG}/oauth2_proxy /bin/ && \
apk del $BUILD_PKGS && \
rm -rf /var/cache/apk/*
cp /var/tmp/oauth2_proxy/${OAUTH2_PROXY_PKG}/oauth2_proxy /bin/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not need to cleanup /var/tmp here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will address.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 1dddf42 and 0f71fa5.

Copy link
Member

@itskingori itskingori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@zacblazic zacblazic merged commit 933e782 into master Sep 28, 2018
@zacblazic zacblazic deleted the switch-to-debian branch September 28, 2018 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants