Return email parameter to docker login

[itskingori]

We use Docker 1.10 on Circle CI which doesn't have that parameter deprecated. This parameter was removed in commit fec8ac0.

[zacblazic]

👍

[itskingori]

@zacblazic Have a look at this issue #5 which I've addressed in a commit that I've just pushed up i.e. cf1fdb2.

[itskingori]

@zacblazic Can I merge? I've added an extra commit i.e. cf1fdb2.

[zacblazic]

Hmm, just wondering how we will handle minor version bumps (for Dockerfile changes, if any)?

[itskingori]

I'm not sure. Yet.

We could have 2.1-1, 2.1-2 or even 2.1.3-1 ... where the former is oauth2_proxy version and anything after is more like a incremental build number defined by us.

[itskingori]

If you want a container with oauth2_proxy v2.1 … it feel natural to look for oauth2_proxy:2.1 image as opposed to oauth2_proxy:1.0.

Example 👇

[zacblazic]

I agree, but we'll need to think about managing history (or lack thereof) in the future! Not sure what the best practice is really.

[zacblazic]

Otherwise 👍

[itskingori]

We could have 2.1-1, 2.1-2 or even 2.1.3-1 ... where the former is oauth2_proxy version and anything after is more like a incremental build number defined by us.

@zacblazic Yes. What about that? ☝️

[zacblazic]

I think that's the best we can do right now, without thinking about it too much. 😁

[itskingori]

Ok. Merging.