Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update & Fix TownyFeature support. #2279

Merged
merged 5 commits into from
Jun 11, 2023

Conversation

LlmDl
Copy link
Contributor

@LlmDl LlmDl commented Jun 9, 2023

Overview

Adds support for TrustedResidents in townblocks and towns, Replaces methods which throw exceptions.

Closes #2249

Description

TrustedResidents are players which have been given specific rights to act as a townblock owner or town owner, as such they would be able to build/destroy in the areas that FAWE would be used.

Also Closes #2249 by doing the following:

  • This commit changes the TownyFeature from only affecting blocks between
    y level 0 and 150, changing it to support the lower and upper bounds of
    the WorldCoord (top to bottom of the world.)

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

Adds support for TrustedResidents in townblocks and towns,
Replaces methods which throw exceptions.

TrustedResidents are players which have been given specific rights to
act as a townblock owner or town owner, as such they would be able to
build/destroy in the areas that FAWE would be used.
@LlmDl LlmDl requested a review from a team as a code owner June 9, 2023 20:59
@github-actions github-actions bot added the Feature This PR adds a new feature label Jun 9, 2023
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'm not a towny user, but if it helps the submitter of the issue, we'll surely get ahead with it.

@LlmDl
Copy link
Contributor Author

LlmDl commented Jun 10, 2023

Thanks for the PR! I'm not a towny user, but if it helps the submitter of the issue, we'll surely get ahead with it.

This isn't going to solve things for that ticket, but it will get FAWE on par with modern Towny.

@NotMyFault
Copy link
Member

Thanks for the PR! I'm not a towny user, but if it helps the submitter of the issue, we'll surely get ahead with it.

This isn't going to solve things for that ticket, but it will get FAWE on par with modern Towny.

I see, thanks for the explanation!

@NotMyFault NotMyFault requested a review from a team June 10, 2023 13:18
This commit changes the TownyFeature from only affecting blocks between
y level 0 and 150, changing it to support the lower and upper bounds of
the WorldCoord (top to bottom of the world.)
@LlmDl LlmDl changed the title Update TownyFeature support. Update & Fix TownyFeature support. Jun 10, 2023
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Jun 10, 2023
@LlmDl
Copy link
Contributor Author

LlmDl commented Jun 10, 2023

Happy update: the FAWEMask will now be made to the correct size with this update. So you should see far less reports of Towny not working (it was only working the magical space between 0 and 156y.)

@dordsor21 dordsor21 merged commit ca4080e into IntellectualSites:main Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug Feature This PR adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

region-restrictions implementation for towny seems to be broken
3 participants