Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing BlockType constructor #2306

Merged
merged 2 commits into from
Jun 19, 2023
Merged

fix: add missing BlockType constructor #2306

merged 2 commits into from
Jun 19, 2023

Conversation

dordsor21
Copy link
Member

@dordsor21
fix: add missing BlockType constructor
e2c172f 
 - Deprecate public BlockType constructors
 - People really should not be initialising their own block types. This can and most likely will cause issues.
 - Fixes #2290
@dordsor21 dordsor21 requested a review from a team as a code owner June 18, 2023 13:02
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Jun 18, 2023
@NotMyFault NotMyFault requested a review from a team June 18, 2023 16:05
@dordsor21 dordsor21 merged commit 01be53e into main Jun 19, 2023
@dordsor21 dordsor21 deleted the fix/missing-blocktype-constructor branch June 19, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreSchwang PierreSchwang PierreSchwang approved these changes

@NotMyFault NotMyFault NotMyFault approved these changes

Assignees
No one assigned
Labels
Bugfix This PR fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing WE API call "void com.sk89q.worldedit.world.block.BlockType.<init>(java.lang.String)"
3 participants
@dordsor21 @NotMyFault @PierreSchwang