split-platform-components works on '.test' files also #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bspaulding, Thanks for your PR! I think it would be nice to add functionality like this, but the currently there are several conventions people use for naming their test files. Are you open to make it configurable? |
|
Sure, was just following the jest defaults to make it simple. How might this work? Should we just expose the regex directly as an rule option? |
|
Did up a quick version of what this might be. I'd love to also make the jest default valid ootb, but I understand if you'd rather not. |
|
Nice! I think that will work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops the split-platform-components from complaining when you import a platform specific component in a platform specific test file:
.ios.test.js.