React native globals #180
Merged
React native globals #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxaggedon Looks good, have you tested if it works though? |
|
@Intellicode yes it did the job on my current react native project =) |
|
@maxaggedon Alright, sounds good to me, I'll create a new release soon, hopefully this week! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I simply copy-pasted it from the react-native repo
.eslintrc(https://github.com/facebook/react-native/blob/58c3bc490143b8d7831a00289e2565f49f5389ef/.eslintrc#L19-L52).I think this is where it should be and I updated
README. I haven't had the time to write any tests for this though...