Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add example of deploying api server to Kubernetes #1488

Merged
merged 3 commits into from
May 6, 2024

Conversation

uzuku
Copy link
Contributor

@uzuku uzuku commented Apr 24, 2024

Modification

Doc: add example of deploying api server to Kubernetes.

Copy link
Collaborator

@zhyncs zhyncs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @uzuku Why not consider adding a new folder named examples, and then write K8s-related configurations in YAML files under this folder? This might make the structure clearer. You can refer to this organization format: https://github.com/triton-inference-server/python_backend/tree/main/examples

@lvhan028
Copy link
Collaborator

Basically, I agree with @zhyncs
but how about making k8s folder in the root directory?
The config content mentioned can be put in a yaml under that folder.
And the api_server user guide can refer to this yaml as an example

@lvhan028 lvhan028 added the documentation Improvements or additions to documentation label Apr 25, 2024
@uzuku
Copy link
Contributor Author

uzuku commented Apr 29, 2024

@lvhan028 @zhyncs I've put the related yaml files under the k8s folder in the root directory.

@lvhan028
Copy link
Collaborator

lvhan028 commented May 3, 2024

pls fix the linting error

pip install pre-commit
cd the/root/path/of/lmdeploy
pre-commit install .
pre-commit run --all-files

@uzuku
Copy link
Contributor Author

uzuku commented May 6, 2024

pls fix the linting error

@lvhan028 fixed

@flyhighzy
Copy link

flyhighzy commented May 6, 2024

Basically, I agree with @zhyncs but how about making k8s folder in the root directory? The config content mentioned can be put in a yaml under that folder. And the api_server user guide can refer to this yaml as an example

The api_server folder under k8s may mislead to kubernetes' own api server, how about rename the yaml's folder to k8s/example?

@lvhan028 lvhan028 merged commit 499b75b into InternLM:main May 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants