Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move renderSafeHashAsHex from cardano-node #410

Merged
merged 1 commit into from Dec 22, 2023

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Dec 20, 2023

Changelog

- description: |
    Add renderSafeHashAsHex, which we want to remove from cardano-node and use in cardano-cli
# uncomment types applicable to the change:
  type:
   - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

We're using this function in two places:

  1. https://github.com/IntersectMBO/cardano-node/blob/76ef0fe7cd716426e41813958569521dd80cda8b/cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/LedgerEvents/Gov/ProposeNewConstitution.hs#L415
  2. https://github.com/input-output-hk/cardano-cli/blob/694782210c6d73a1b5151400214ef691f6f3ecb0/cardano-cli/src/Cardano/CLI/EraBased/Run/Governance/Hash.hs#L67

but this function is better placed here, and reused from these existing callers.

How to trust this PR

This PR moves code around repos

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • NA New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@smelc
Copy link
Contributor Author

smelc commented Dec 20, 2023

Will be merged after #411 lands

@smelc smelc force-pushed the smelc/move-renderSafeHashAsHex-from-cardano-node branch from a0bc5ac to 5d9cb77 Compare December 20, 2023 16:34
@smelc smelc added this pull request to the merge queue Dec 22, 2023
Merged via the queue into main with commit d589604 Dec 22, 2023
20 checks passed
@smelc smelc deleted the smelc/move-renderSafeHashAsHex-from-cardano-node branch December 22, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants