Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bech32 prefixes of committee keys #435

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Jan 24, 2024

Changelog

- description: |
    Fix that bech32 prefixes for CC keys were incorrect
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Was looking at CC keys code for IntersectMBO/cardano-cli#586 and stumbled upon what looked like a copy/paste typo.

How to trust this PR

  • That is a good question. Probably we should be testing this in cardano-cli.
  • That being said, I ran cardano-cli's tests against this PR, and all tests passed. So at least we're not breaking anything, but it's consistent with my impression that we are not testing this.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc
Copy link
Contributor Author

smelc commented Jan 24, 2024

cc @gitmachtl, as I'm a bit surprised we are only seeing this now, but maybe this wasn't tested yet?

@smelc smelc marked this pull request as ready for review January 24, 2024 16:34
@smelc smelc enabled auto-merge January 24, 2024 16:40
@Ryun1
Copy link
Member

Ryun1 commented Jan 24, 2024

Hey @smelc

We have defined bech32 prefixes for committee keys already defined via CIP-05; here.

@smelc smelc force-pushed the smelc/fix-cc-bech32-prefixes branch from d04c96a to f25dc6f Compare January 24, 2024 16:52
@smelc
Copy link
Contributor Author

smelc commented Jan 24, 2024

Thanks @Ryun1! I amended my changes so that they match the CIP-05.

Great catch 😍

@Ryun1
Copy link
Member

Ryun1 commented Jan 24, 2024

Thanks @Ryun1! I amended my changes so that they match the CIP-05.

Great catch 😍

Thank @gitmachtl for giving me the heads up 🤩

@smelc smelc added this pull request to the merge queue Jan 26, 2024
Merged via the queue into main with commit 709ab02 Jan 26, 2024
18 checks passed
@smelc smelc deleted the smelc/fix-cc-bech32-prefixes branch January 26, 2024 09:33
newhoggy added a commit that referenced this pull request Mar 11, 2024
…no-8.31.0.0

Update to `cardano-8.31.0.0`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants