Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error "evaluateTransactionFee: TODO support Byron key witnesses" #478

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

newhoggy
Copy link
Collaborator

@newhoggy newhoggy commented Mar 11, 2024

Changelog

- description: |
    Remove error `"evaluateTransactionFee: TODO support Byron key witnesses"` in `estimateMinFeeTx`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

The Byron functionality was already implemented in the ledger.

See IntersectMBO/cardano-cli#534 (comment)

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@newhoggy newhoggy added this pull request to the merge queue Mar 11, 2024
Merged via the queue into main with commit 53a4d8c Mar 11, 2024
24 checks passed
@newhoggy newhoggy deleted the newhoggy/remove-todo-support-byron-key-witnesses branch March 11, 2024 12:33
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants